While you are in drivers/watchdog/hpwdt.c replacing panic() with
nmi_panic() can you also fix a few more of the broken strings? The
Linux style guide specfiically says NOT to break strings that are user
visible because it breaks "grep". So:
- panic("An NMI occurred. Depending on your system the reason "
+ nmi_panic(regs, "An NMI occurred. Depending on your system the reason "
"for the NMI is logged in any one of the following "
"resources:\n"
"1. Integrated Management Log (IML)\n"
Should probably be:
- panic("An NMI occurred. Depending on your system the reason "
- "for the NMI is logged in any one of the following "
- "resources:\n"
+ nmi_panic(regs, "An NMI occurred. Depending on your system the
reason for the NMI is logged in any one of the following resources:\n"
"1. Integrated Management Log (IML)\n"
So it's okay to break on "\n", but not in the middle of a line.
--
Philip Pokorny, RHCE
Chief Technology Officer
PENGUIN COMPUTING, Inc
www.penguincomputing.com
Changing the world through technical innovation
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
