On Fri, 2023-11-03 at 14:45 +0000, Jonathan Cameron wrote:
> On Fri,  3 Nov 2023 16:45:18 +1030
> Andrew Jeffery <and...@codeconstruct.com.au> wrote:
> 
> > Consolidate several necessary allocations into one to reduce the number
> > of possible error paths.
> > 
> > Signed-off-by: Andrew Jeffery <and...@codeconstruct.com.au>
> Gets rid of some of the devm_kfree() fun, so I'm in favor of the change :)
> 
> One trivial comment inline.
> 
> Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>

Thanks.

> > @@ -478,19 +476,15 @@ static int kcs_bmc_ipmi_add_device(struct 
> > kcs_bmc_device *kcs_bmc)
> >  
> >     spin_lock_init(&priv->lock);
> >     mutex_init(&priv->mutex);
> > -
> Unrelated change...

Ack, will drop in v2.


_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to