On Tue, Apr 15, 2025 at 11:51:56AM +0300, Andy Shevchenko wrote: > Debian clang version 19.1.7 is not happy when compiled with > `make W=1` (note, CONFIG_WERROR=y is the default): > > ipmi_si_platform.c:268:15: error: cast to smaller integer type 'enum si_type' > from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] > 268 | io.si_type = (enum > si_type)device_get_match_data(&pdev->dev); > > Fix this by intermediate cast to the uintptr_t, that makes compiler happy.
Unless things have changed recently, Linus prefers "unsigned long" per https://patchwork.kernel.org/project/linux-hardening/patch/20220616143617.449094-1-ja...@zx2c4.com/#24899749 And it would match what is in the match table. Is that change ok? -corey > > Fixes: 5be50eb5ae99 ("ipmi: si: Use device_get_match_data()") > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > drivers/char/ipmi/ipmi_si_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c > b/drivers/char/ipmi/ipmi_si_platform.c > index 550cabd43ae6..47d3cbeb3fa0 100644 > --- a/drivers/char/ipmi/ipmi_si_platform.c > +++ b/drivers/char/ipmi/ipmi_si_platform.c > @@ -265,7 +265,7 @@ static int of_ipmi_probe(struct platform_device *pdev) > } > > memset(&io, 0, sizeof(io)); > - io.si_type = (enum si_type)device_get_match_data(&pdev->dev); > + io.si_type = (enum > si_type)(uintptr_t)device_get_match_data(&pdev->dev); > io.addr_source = SI_DEVICETREE; > io.irq_setup = ipmi_std_irq_setup; > > -- > 2.47.2 > _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer
