From: Miao Wang <[email protected]>
When the bmc resets, the recovery procedure require to reconfigure the
parent device. The driver assumes that the parent device should be LS7A.
Add a sanity check on initialization to ensure this and prevent from
accidentally operating on non-LS7A ports.
Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support")
Signed-off-by: Miao Wang <[email protected]>
---
drivers/mfd/ls2k-bmc-core.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c
index
27f6e096404d67459038a0607378057ec7ef69ab..b02e4955e9b04f517892a18b2ef103b5e481a238
100644
--- a/drivers/mfd/ls2k-bmc-core.c
+++ b/drivers/mfd/ls2k-bmc-core.c
@@ -35,6 +35,15 @@
#define LS2K_IPMI3_RES_START (LS2K_IPMI2_RES_START +
LS2K_IPMI_RES_SIZE)
#define LS2K_IPMI4_RES_START (LS2K_IPMI3_RES_START +
LS2K_IPMI_RES_SIZE)
+/* LS7A port Device IDs */
+#define DEV_LS7A1K_PCIE_PORT0 0x7a09
+#define DEV_LS7A1K_PCIE_PORT1 0x7a19
+#define DEV_LS7A1K_PCIE_PORT2 0x7a29
+#define DEV_LS7A2K_PCIE_PORT0 0x7a39
+#define DEV_LS7A2K_PCIE_PORT1 0x7a49
+#define DEV_LS7A2K_PCIE_PORT2 0x7a59
+#define DEV_LS7A2K_PCIE_PORT3 0x7a69
+
#define LS7A_PCI_CFG_SIZE 0x100
/* LS7A bridge registers */
@@ -477,6 +486,24 @@ static int ls2k_bmc_parse_mode(struct pci_dev *pdev,
struct simplefb_platform_da
return -EINVAL;
}
+static const struct pci_device_id ls7a_ports[] = {
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A1K_PCIE_PORT0) },
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A1K_PCIE_PORT1) },
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A1K_PCIE_PORT2) },
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT0) },
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT1) },
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT2) },
+ { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT3) },
+ { }
+};
+
+static bool ls2k_check_parent(struct pci_dev *dev)
+{
+ struct pci_dev *parent = dev->bus->self;
+
+ return parent && pci_match_id(ls7a_ports, parent) != NULL;
+}
+
static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
struct simplefb_platform_data pd;
@@ -488,6 +515,11 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const
struct pci_device_id *id)
if (ret)
return ret;
+ if (!ls2k_check_parent(dev)) {
+ dev_err(&dev->dev, "Expected to be connected to LS7A PCI-E
port\n");
+ return -ENODEV;
+ }
+
ddata = devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL);
if (!ddata)
return -ENOMEM;
--
2.49.0
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
