1) Some files have empty diffs:
modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/dirent.[h|c]
modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/wdirent.c
and some more.
2) what's the purpose of surrounding in
modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/gbacktrace.c
in GSTREAMER_LITE ? Can we just compile with G_ENABLE_DEBUG if needed ?
3)
modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/gutils.c
as far as I know we compile with G_DISABLE_DEPRECATED so this code won't
be included hence why to change ?
4) I'm not sure we need these
modules/media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-bad/COPYING
files I included them long ago without any reason.
5) Where do we need functions from
modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/deprecated/gthread.h
?
Maybe if it's our code we could rewrite it to make sure we don't use
deprecated ghtread at all ?
Overall looks fine. So approved.
K
On 05.09.2015 6:20, Alexander Matveev wrote:
Hi Kirill and Kevin,
Please review the fix:
https://bugs.openjdk.java.net/browse/JDK-8134996
http://cr.openjdk.java.net/~almatvee/8134996/webrev.00/
- Added missing GSTREAMER_LITE.
- Fixed some white spaces.
- Fixed line ending for some files.
- Several files were not merged correctly with latest GStreamer.
- Deleted several unused files.
Thanks,
Alexander
