This is going into 9-dev first, right? I'll add comments in JIRA.
-- Kevin David DeHaven wrote:
Kevin, Alexander, can you please review this fairly trivial fix: https://bugs.openjdk.java.net/browse/JDK-8144678 The fix is only five lines, no webrev. It's pasted in a comment and below for reference. --- cut here --- diff --git a/modules/media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm b/modules/media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm --- a/modules/media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm +++ b/modules/media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm @@ -401,6 +401,11 @@ - (void) dispose { @synchronized(self) { if (!isDisposed) { + if (_player != nil) { + // this should stop and dealloc the audio processor + _player.currentItem.audioMix = nil; + } + if (_playerOutput != nil) { [_playerItem removeOutput:_playerOutput]; [_playerOutput setDelegate:nil queue:nil]; --- cut here --- -DrD-