I've reviewed the code and run a number of tests. Things look fine.
I spotted at least one thing that I brought up in the 2D Marlin review, but since the 2 source bases are moving towards
synchronizing with each other I didn't look too closely since many of the changes in the 2D Marlin update are things
that are already "fixed" in this FX Marlin code, so I thought I would focus my scrutiny more on the 2D review instead.
Would this code base be affected by the review comments I made there? Did you want to hold both until they both are
ready to go in and then push them at the same time (to keep them in sync)?
Minimally, it is time to file a bug against FX for this...
...jim
On 4/19/17 11:35 PM, Laurent Bourgès wrote:
Hi,
Please review this MarlinFX upgrade to Marlin 0.7.5:
JBS: no bug yet for OpenJFX 10
webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.0/
Changes:
- Renderers: fixed block processing
- dead code & few comment removals in Strokers
- fixed all floating-point number literals to be x.0f or x.0d to simplify
the conversion between float & double variants
PS: I plan to run later FindBugs, Netbeans & IntelliJ code analysis tools
to fix any warning
Cheers,
Laurent
