Ok, so back to building everything on my own - fine for me...
Sven On Wed, Mar 14, 2018 at 10:16 PM, Kevin Rushforth < [email protected]> wrote: > One more thing to note. You won't actually be able to use JDK 11 as your > boot JDK, since gradle 4.x does not yet run with JDK 11. See: > > https://github.com/gradle/gradle/issues/4515 > https://bugs.openjdk.java.net/browse/JDK-8199069 > > > -- Kevin > > > Sven Reimers wrote: > > Already downloading.. > > Thanks > > Sven > > Am 14.03.2018 22:08 schrieb "Kevin Rushforth" <[email protected] > >: > >> As a solution, you can download the latest EA build of Oracle JDK 11 here: >> >> http://jdk.java.net/11/ >> >> and copy the libjfxwebkit.dylib from there into your FX build. >> >> You could also build webkit yourself, but that increases the build time >> significantly (although it pretty easy to set up on Mac...not so much on >> Windows). >> >> -- Kevin >> >> >> Kevin Rushforth wrote: >> >>> This will happen if you: A) don't build WebKit; and B) are running with >>> a libwebkit.dylib that is out of date w.r.t., the java source. >>> >>> In your case it looks like you are using the native webkit library from >>> JDK 9.0.4 and the sources from jfx-dev (11-ea). >>> >>> -- Kevin >>> >>> >>> Sven Reimers wrote: >>> >>>> No further test failures due to locale, but I get this... >>>> >>>> > Task :web:test FAILED >>>> # >>>> # A fatal error has been detected by the Java Runtime Environment: >>>> # >>>> # SIGSEGV (0xb) at pc=0x0000000107dddeaa, pid=73787, tid=38147 >>>> # >>>> # JRE version: Java(TM) SE Runtime Environment (9.0+11) (build 9.0.4+11) >>>> # Java VM: Java HotSpot(TM) 64-Bit Server VM (9.0.4+11, mixed mode, >>>> tiered, compressed oops, g1 gc, bsd-amd64) >>>> # Problematic frame: >>>> # V [libjvm.dylib+0x3ddeaa] >>>> # >>>> # No core dump will be written. Core dumps have been disabled. To >>>> enable core dumping, try "ulimit -c unlimited" before starting Java again >>>> # >>>> # An error report file with more information is saved as: >>>> # /Users/sven/oss/openjfx/jfx-dev-rt/modules/javafx.web/hs_err_pid73787.log >>>> >>>> # >>>> # If you would like to submit a bug report, please visit: >>>> # http://bugreport.java.com/bugreport/crash.jsp >>>> # >>>> >>>> ;-) >>>> >>>> Sven >>>> >>>> On Mon, Mar 12, 2018 at 4:55 PM, Kevin Rushforth < >>>> [email protected] <mailto:[email protected]>> wrote: >>>> >>>> >>>> >>>> Laurent Bourgès wrote: >>>> >>>>> Kevin, >>>>> >>>>> It is possible to define the Locale (set user.language=...) in >>>>> the gradle build file, that would avoid touching the java code at >>>>> all. >>>>> >>>> >>>> I suppose this could be done, and if there are many such failing >>>> tests, it might be an OK short-term solution. It's probably not >>>> the best long-term solution, since I think it is better for any >>>> test that is sensitive to the Locale to set it in the test itself. >>>> >>>> Sven: if you run using the --continue option (so it won't stop >>>> after the first batch of failing tests), are there any more tests >>>> that fail in other modules? >>>> >>>> -- Kevin >>>> >>>> >>>> >>>> >>>> >>>>> I have no opinion what is preferable to have less maintenance >>>>> work or problems in future. >>>>> >>>>> Laurent >>>>> >>>>> 2018-03-12 16:09 GMT+01:00 Kevin Rushforth >>>>> <[email protected] <mailto:[email protected]>>: >>>>> >>>>> I haven't run these with a Locale other than en_US, but given >>>>> the nature of the failure, it looks like you may have >>>>> discovered another Locale-related test bug. >>>>> >>>>> We had another test that was fixed by setting the default >>>>> Locale to Locale.US in a static @BeforeClass method in the >>>>> test class [1]. Perhaps a similar solution is needed here. >>>>> >>>>> -- Kevin >>>>> >>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8160039 >>>>> <https://bugs.openjdk.java.net/browse/JDK-8160039> >>>>> >>>>> >>>>> >>>>> Sven Reimers wrote: >>>>> >>>>> Hi, >>>>> >>>>> getting back into the OpenJFX I started with a fresh >>>>> clone and ran gradle >>>>> test.. >>>>> >>>>> I got >>>>> >>>>> test.javafx.scene.control.SpinnerTest > >>>>> dblSpinner_testToString_valueInRange FAILED >>>>> junit.framework.ComparisonFailure: null >>>>> expected:<0[.]3> but was:<0[,]3> >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:81) >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:87) >>>>> at >>>>> test.javafx.scene.control.Spin >>>>> nerTest.dblSpinner_testToString_valueInRange(SpinnerTest.java:607) >>>>> >>>>> test.javafx.scene.control.SpinnerTest > >>>>> dblSpinner_testFromString_valueInRange FAILED >>>>> junit.framework.AssertionFailedError: expected:<0.3> >>>>> but was:<0.0> >>>>> at junit.framework.Assert.fail(Assert.java:47) >>>>> at >>>>> junit.framework.Assert.failNotEquals(Assert.java:283) >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:64) >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:71) >>>>> at >>>>> test.javafx.scene.control.Spin >>>>> nerTest.dblSpinner_testFromString_valueInRange(SpinnerTest.java:615) >>>>> >>>>> test.javafx.scene.control.SpinnerTest > >>>>> test_jdk_8150946_testCancel FAILED >>>>> junit.framework.ComparisonFailure: null >>>>> expected:<2[.]5> but was:<2[,]5> >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:81) >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:87) >>>>> at >>>>> test.javafx.scene.control.Spin >>>>> nerTest.test_jdk_8150946_testCancel(SpinnerTest.java:1334) >>>>> >>>>> test.javafx.scene.control.SpinnerTest > >>>>> test_jdk_8150946_testCommit_valid >>>>> FAILED >>>>> junit.framework.AssertionFailedError: expected:<2.5> >>>>> but was:<2.0> >>>>> at junit.framework.Assert.fail(Assert.java:47) >>>>> at >>>>> junit.framework.Assert.failNotEquals(Assert.java:283) >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:64) >>>>> at >>>>> junit.framework.Assert.assertEquals(Assert.java:71) >>>>> at >>>>> test.javafx.scene.control.Spin >>>>> nerTest.test_jdk_8150946_testCommit_valid(SpinnerTest.java:1308) >>>>> >>>>> This is with gradle 46, 9.0.4 on a german locale OS X... >>>>> >>>>> Any ideas what to look for? >>>>> >>>>> Thanks >>>>> >>>>> Sven >>>>> >>>>> >>>>> >>>>> -- -- Laurent Bourgès >>>>> >>>> >>>> >>>> >>>> >>>> -- >>>> Sven Reimers >>>> >>>> * Senior Expert Software Architect >>>> * Java Champion >>>> * NetBeans Dream Team Member: http://dreamteam.netbeans.org >>>> * Community Leader NetBeans: http://community.java.net/netbeans >>>> Desktop Java: >>>> http://community.java.net/javadesktop >>>> * JUG Leader JUG Bodensee: http://www.jug-bodensee.de >>>> * Duke's Choice Award Winner 2009 >>>> >>>> * XING: https://www.xing.com/profile/Sven_Reimers8 >>>> * LinkedIn: http://www.linkedin.com/in/svenreimers >>>> >>> -- Sven Reimers * Senior Expert Software Architect * Java Champion * NetBeans Dream Team Member: http://dreamteam.netbeans.org * Community Leader NetBeans: http://community.java.net/netbeans Desktop Java: http://community.java.net/javadesktop * JUG Leader JUG Bodensee: http://www.jug-bodensee.de * Duke's Choice Award Winner 2009 * XING: https://www.xing.com/profile/Sven_Reimers8 * LinkedIn: http://www.linkedin.com/in/svenreimers
