Thanks, Prasanta.
As an additional note to reviewers:
The JDK portion of this change (JDK-8202199) is the subject for this review.
The FX webrev is enough to be able to test the JDK side, but will need
additional refactoring (to allow it to continue to build / run with JDK
10) before being ready for review. If you spot something of concern in
the FX webrev, please feel free to bring it up, but don't spend time
doing a thorough review just yet.
-- Kevin
On 5/4/2018 5:00 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review an enhancement to remove the tight coupling of JDK
internal class from FX so that
when javafx.* modules are removed from Openjdk build in jdk11, FX in
general, and fx swing interop, in particular, can still build and
function.
Right now, FX uses 6 jdk internal packages
sun.swing, sun.awt, java.awt.dnd.peer, sun.awt.dnd, sun.awt.image and
sun.java2d.
However, the goal is not to use qualified exports of these internal
packages once FX is removed to be built along with JDK,
The solution will define a new "jdk.unsupported.desktop" module that
exports public API
that is intended to be used by the javafx.swing module (but it does so
with public exports and not qualified exports).
The idea is the same as jdk.unsupported, in that it is documented as
being unsupported.
Further, since it is only intended to be used by javafx.swing, it need
not be in the default module graph.
The module-info.java will look like this:
|module jdk.unsupported.desktop { requires transitive java.desktop;
exports jdk.swing.interop; } |||
Enhancement: https://bugs.openjdk.java.net/browse/JDK-8202199,
https://bugs.openjdk.java.net/browse/JDK-8195811
webrev: cr.openjdk.java.net/~psadhukhan/fxswing.6/
CSR: https://bugs.openjdk.java.net/browse/JDK-8202175
Regards
Prasanta
||
