Tom,
I'll be sure to test SWT interop as part of my review of this fix.
-- Kevin
On 10/3/2018 4:00 AM, Tom Schindl wrote:
Hi,
While i can not comment on the change. This is really really great news
for all people integrating JavaFX into SWT!
Tom
On 03.10.18 12:26, Pankaj Bansal wrote:
Hi All,
Please review the patch for 8u-dev backport for HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8087516"JDK-8087516. It adds
conditional support for gtk3.
Along with the enhancement, following bug fixes have also been included in the
backport webrev
1. https://bugs.openjdk.java.net/browse/JDK-8159892: [GTK3] invalid
rendering of FX app stage in case of scaling
2. https://bugs.openjdk.java.net/browse/JDK-8163496: Rework Glass GTK to
correct gtk3 structure sizes
3. https://bugs.openjdk.java.net/browse/JDK-8145837: Remove deprecated
GTK2 calls in JavaFX
4. https://bugs.openjdk.java.net/browse/JDK-8165562: Upgrade to newer
version of SWT for build/test
5. https://bugs.openjdk.java.net/browse/JDK-8171330: Issues with
transparent stage and GTK
6. https://bugs.openjdk.java.net/browse/JDK-8171976: Linux: JavaFX window
not painted with background when using GTK 3
7. https://bugs.openjdk.java.net/browse/JDK-8166414: Scene returns
incorrect coordinates
8. https://bugs.openjdk.java.net/browse/JDK-8166147: Ubuntu 16.04:
expandable content goes outside of the alert dialog
9. https://bugs.openjdk.java.net/browse/JDK-8152421: After initing the
modality of a non-primary stage to MODAL, closing that stage causes the primary
stage to become non-resizable
10. https://bugs.openjdk.java.net/browse/JDK-8090249: [Linux] Restoring owner
stage after minimize does not restore position of child stage
11. https://bugs.openjdk.java.net/browse/JDK-8173901: Linux: Position of
Stage is not restored after exiting full screen
12. https://bugs.openjdk.java.net/browse/JDK-8175204: Linux: Dialog windows
come up 1-pixel wide
13. https://bugs.openjdk.java.net/browse/JDK-8175205: Linux: Stage initially
in full-screen mode not shown when exiting full-screen
14. https://bugs.openjdk.java.net/browse/JDK-8175822: Pulldown position
regression and not painting correctly tooltips regression
15. https://bugs.openjdk.java.net/browse/JDK-8176844: Menus not always
selected properly with GTK 3
16. https://bugs.openjdk.java.net/browse/JDK-8172219: Allow compiling without
GTK 3.0 being installed
17. https://bugs.openjdk.java.net/browse/JDK-8157002 Toggle gtk version if
SWT used via FXCanvas
18. https://bugs.openjdk.java.net/browse/JDK-8156491: Autodetect GTK version
for JFX
The original gtk3 backport patch applied cleanly, but the bugs did not apply
cleanly. So a review is required.
I have run the full gradle tests on Ubuntu 14.04 LTS, Ubuntu 16.04 LTS, Ubuntu
18.04 and have done sanity testing on Oracle Linux 7.5.
webrev: http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8087516
JDK 9 Changeset: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8c6d0386d3f5
Regards,
Pankaj
