On Thu, 17 Oct 2019 15:28:30 GMT, mruzicka <github.com+562920+mruzi...@openjdk.org> wrote:
> On Thu, 17 Oct 2019 15:28:28 GMT, mruzicka > <github.com+562920+mruzi...@openjdk.org> wrote: > >> Secondary event loop introduced as a means of synchronization with the >> JavaFX Application thread in [1] never terminates as the >> SecondaryLoop.exit() call is not reached because the thread is blocked in >> the SecondaryLoop.enter() call. >> This patch fixes the problem by submitting the UI work (including the call >> to the SecondaryLoop.exit() method) before entering the secondary loop. >> >> [1] >> https://github.com/openjdk/jfx/commit/7cf2dfa0b3c5bfd0f1a2de36d46b62f7e9e256c4 >> >> ---------------- >> >> Commits: >> - 9483ccde: 8231372: Correctly terminate secondary event loop in >> JFXPanel.setScene() >> >> Changes: https://git.openjdk.java.net/jfx/pull/16/files >> Webrev: https://webrevs.openjdk.java.net/jfx/16/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8231372 >> Stats: 6 lines in 1 file changed: 1 ins; 2 del; 3 mod >> Patch: https://git.openjdk.java.net/jfx/pull/16.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/16/head:pull/16 > > @kevinrushforth I believe you should be able to move forward with the review > of this PR now as I've filed a bug report for the problem and signed the OCA > as required. (As I did not know I needed to have my github account associated > with the OCA, I did not include it in my details. I've asked Dalibor Topic > from the Java SE PM team to help me have that fixed or get in touch with you > to confirm my signing of the OCA.) @mruzicka once Dalibor connects your OCA with your GitHub account, this review will be able to proceed. PR: https://git.openjdk.java.net/jfx/pull/16
