... if changes are "just" a re-arrangement of code (like https://github.com/openjdk/jfx/pull/6 - 8207957: TableSkinUtils should not contain actual code implementation)?
In an ideal world, there would be a safety-net of tests (they would have been written at the time the old code was pushed - wouldn't they ;). All we would need to do is run them to ensure that our re-arrangement doesn't break anything.
In the real world and that particular pull request above, there are not tests (that I could find, maybe overlooked them).
Now the question: is the contributor responsible for writing those missing tests? The two extremes are
- yes, it's a good opportunity ;) And it is mandatory (probably?) for all public/protected api. A new protected method with specification was condensed and should be tested. - no, nothing changed, the tests were always missing and all still live ;) so doing nothing is just fine
What's the procedure here? -- Jeanette
