On Thu, 21 Nov 2019 23:39:36 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> On Thu, 21 Nov 2019 01:00:33 GMT, Alexander Matveev <almat...@openjdk.org> > wrote: > >> - Upgraded GStreamer to 1.16.1 >> - Upgraded GLib to 2.62.2. >> - Removed glib-liteD.def, since it almost identical to release version >> glib-lite.def. Debug build will use glib-lite.def. >> - No changes to other parts of code, except minor changes to makefiles. >> >> ---------------- >> >> Commits: >> - 98e1157b: 8230610: Upgrade GStreamer to the latest 1.16.1 >> >> Changes: https://git.openjdk.java.net/jfx/pull/48/files >> Webrev: https://webrevs.openjdk.java.net/jfx/48/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8230610 >> Stats: 46378 lines in 491 files changed: 17416 ins; 6527 del; 22435 mod >> Patch: https://git.openjdk.java.net/jfx/pull/48.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/48/head:pull/48 > > Looks good to me. I did have one question, but it's just for my information. > > modules/javafx.media/src/main/native/gstreamer/3rd_party/glib/glib/gdate.c > line 2601: > >> 2600: #pragma GCC diagnostic push >> 2601: #pragma GCC diagnostic ignored "-Wformat-nonliteral" >> 2602: #endif // G_OS_WIN32 > > Did you add this because it will fail on 32-bit Windows without it? This > logic is otherwise untouched as part of the upgrade. > > ---------------- > > Approved by kcr (Lead). G_OS_WIN32 defined for both 32 and 64-bit Windows. Yes, I disable it because build fails on Windows due to unknown GCC pragma. PR: https://git.openjdk.java.net/jfx/pull/48
