On Wed, 11 Dec 2019 01:18:55 GMT, Ambarish Rapte <[email protected]> wrote:
>> Need for the change >> [[JDK-8227808](https://bugs.openjdk.java.net/browse/JDK-8227808)]: >> Currently GTK3 is the default on Linux. However, there is build logic that >> will skip building glassgtk3 if the gtk3 development libraries are not >> installed. This creates a situation where the build will succeed, but the >> resulting JavaFX library will fail to run unless you explicitly force GTK2 >> with "-Djdk.gtk.version=2". >> >> How to verify the change: >> On a Linux system without gtk2 and gtk3 packages, >> 1. Clone jfx and run gradle sdk. >> -> Build should fail with an error for missing GTK3 packages. >> >> 2. Install gtk3 packages, remove build directory and run gradle clean sdk. >> -> Build should fail with an error for missing GTK2 packages. >> >> 3. Install gtk2 packages, remove build directory and run gradle clean sdk. >> -> Build should finish without any error. >> >> Build verification: >> 1. Run a JavaFX application with -Djdk.gtk.verbose=true >> Verify the verbose message, the default glassgtk3 library should be used. >> >> 2. Run a JavaFX application with -Djdk.gtk.verbose=true -Djdk.gtk.version=2 >> Verify the verbose message, glassgtk2 library should be used. >> >> 3. Run a JavaFX application with -Djdk.gtk.verbose=true -Djdk.gtk.version=3 >> Verify the verbose message, glassgtk3 library should be used. > > The pull request has been updated with 1 additional commit. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/61
