On Tue, 28 Jan 2020 09:08:35 GMT, Dean Wookey <dwoo...@openjdk.org> wrote:
>> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue >> removingThenAddingNodeToDifferentBranchGetsIneritableStyle >> movingNodeToDifferentBranchGetsNewFontStyleTest >> >> I doubt this will cause a significant performance decrease. I think it's >> worth it for correctness. The only other thing is that I kept the fix to the >> minimum, but technically canReuseHelper now has a side effect. I could try >> rewrite some things if necessary, or maybe rename the method? Else leave it >> as is? >> >> Originally introduced here: >> https://bugs.openjdk.java.net/browse/JDK-8090462/ >> https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab > > The pull request has been updated with 1 additional commit. modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 2: > 1: /* > 2: * Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights > reserved. > 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. Minor : As this is a new file being added, there should be just one 2020 (The year in which file has been introduced) ------------- PR: https://git.openjdk.java.net/jfx/pull/87
