On Mon, 10 Feb 2020 20:57:30 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> * add support for the "resource" protocol (which is used in the GraalVM URLs >> pointing to statically bundled resources) >> * avoid duplicate symbols with different gst plugins >> * statically register gst plugins > > I added a comment about using an ifdef for `GSTREAMER_LITE` in one of the > modified files (the others are fine, since those files are entirely > FX_specific). > > One other question: do you need any changes in > [ConnectionHolder.java](https://github.com/openjdk/jfx/blob/c334ba810293683b7e510a91be3496f7a872c574/modules/javafx.media/src/main/java/com/sun/media/jfxmedia/locator/ConnectionHolder.java)? > That class checks for URL scheme to determine whether a URL is seekable. As for the ConnectionHolder: the URIConnectionHolder will be used. This indeed will by default return false for `isSeekable` hence that functionality will now not be possible using the "resource" protocol. ------------- PR: https://git.openjdk.java.net/jfx/pull/109
