On Fri, 14 Feb 2020 14:06:28 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java >> line 152: >> >>> 151: >>> 152: new KeyMapping(LEFT, (rtl? e -> selectRightCell() : e >>> -> selectLeftCell())), >>> 153: new KeyMapping(KP_LEFT, (rtl? e -> selectRightCell() : >>> e -> selectLeftCell())), >> >> ... so a keyMapping based on the initial condition will fail after a change >> of orientation, or what am I missing? >> >> (aside: I really hate this review ui, can't seem to make it take several >> comments ... argghh) > > To add multiple comments, go to the `Files changed` tab and click on a line > of code to add a comment there. Select `Start a review` rather than `Add > single comment`. This way you can batch up multiple comments. Then you select > `Finish Review` in the upper right. thanks, Kevin - that's what I tried, but it refused to accept the second .. so sticking with single comments until I feel like digging into this weirdness. ------------- PR: https://git.openjdk.java.net/jfx/pull/114
