On Thu, 20 Feb 2020 12:19:07 GMT, Johan Vos <[email protected]> wrote:
>> * add support for the "resource" protocol (which is used in the GraalVM URLs
>> pointing to statically bundled resources)
>> * avoid duplicate symbols with different gst plugins
>> * statically register gst plugins
>
> The pull request has been updated with 4 additional commits.
Looks good to me. I ran a full test on Linux with the default dynamic libraries
and all looks good. I also tested that the `resource` protocol throws an
informative exception:
MediaException: MEDIA_INACCESSIBLE : unknown protocol: resource
I asked one question, but whatever you decide is fine with me.
modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 74:
> 73: private static final boolean IOS = os.startsWith("iOS");
> 74: private static final boolean STATIC_BUILD = "Substrate
> VM".equals(System.getProperty("java.vm.name"));
> 75:
Is it always going to be the case that STATIC_BUILD == is SubStrate VM?
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/109
