On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >> [JDK-8237469](https://bugs.openjdk.java.net/browse/JDK-8237469). >> RegionCSSTest is a victim of this bug. >> >> Except for the systemTests project, all unit tests are run in the same JVM, >> so each test class must ensure that any modified global state is restored >> after the tests are run. The CssStyleHelperTest leaves a userAgentStyleSheet >> set, which is a global (per Application) attribute, so any subsequent tests >> will be run with that stylesheet set. If the last test that is run in >> CssStyleHelperTest sets a style sheet with `"-fx-background"` then it will >> cause assertion failures in 78 of the tests in RegionCSSTest. >> >> The fix is to cleanup the global userAgentStyleSheet, along with any other >> state that is set, in an `@AfterClass` cleanup method. > > The pull request has been updated with 1 additional commit. Looks good to me. Just the dates in the copyright headers need to be updated. ------------- Changes requested by dwookey (Author). PR: https://git.openjdk.java.net/jfx/pull/124
