On Wed, 26 Feb 2020 19:51:38 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8236832 >> >> - This issue most likely caused by changes in AVFoundation APIs on macOS >> 10.15. >> - Getting currentTime from AVPlayer was blocked if it is done from >> ProcessAudioTap callback (used for spectrum, equalizer and volume) on first >> call. If we reading currentTime after first callback returns, then it will >> not block. Fixed by not reading currentTime on first call and default it 0. > > Looks good to me. > > I think this is a safe enough change that a single reviewer will be > sufficient, although we should wait for one day to see if anyone else has > comments. I tested this on both macOS 10.15.2 (Catalina) and macOS t0.13.6 (High Sierra) and everything looks good. ------------- PR: https://git.openjdk.java.net/jfx/pull/126
