On Tue, 3 Mar 2020 13:06:52 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

>> The selection model of ListView stores a strong reference to the most 
>> recently changed item in 
>> `SelectedItemsReadOnlyObservableList.itemsListChange`, which causes a leak.
>> 
>> Fix: 
>> The below member variables and method of class 
>> SelectedItemsReadOnlyObservableList are not required anymore.
>> Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
>> Method: setItemsList
>> 
>> These members were added when this class was created for 
>> [JDK-8154216](https://bugs.openjdk.java.net/browse/JDK-8154216).
>> But after the fix for 
>> [JDK-8152396](https://bugs.openjdk.java.net/browse/JDK-8152396), these class 
>> members are not required.
>> 
>> Verification:
>> No failure in existing tests and added a new test.
>
> The pull request has been updated with 1 additional commit.

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.java.net/jfx/pull/132

Reply via email to