On Wed, 11 Mar 2020 12:38:48 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8200224
>> cleaned up code based on code review
>
> tests/system/src/test/java/test/javafx/scene/control/ProgressIndicatorLeakTest.java
> line 114:
>
>> 113: }
>> 114: public static void createGarbage() {
>> 115: LinkedList list = new LinkedList<Integer>();
>
> I think the test should consistently pass or fail without using this method.
> Can you please check and remove this method if can be.
> I tested once and it passes.
It's quite dependent on how the JVM and the GC are implemented.
It might be only really required when elements get into a very old generation
of the heap.
I remember that I required this method to make similar tests stable.
Nevertheless, I've now removed the method. This way the test is also more
similar to the other memory tests in the jfx
project..
-------------
PR: https://git.openjdk.java.net/jfx/pull/71
