On Tue, 28 Apr 2020 23:17:48 GMT, Kevin Rushforth <[email protected]> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Search javafx.platform.properties in jfx-runtime/lib directory
>
> Marked as reviewed by kcr (Lead).
Pending review by @johanvos
> modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 241:
>
>> 240: s.lastIndexOf('/'), s.lastIndexOf('\\'));
>> 241: return new File(new URL(s.substring(0, lastIndexOfSlash +
>> 1)).getPath());
>> 242: } catch (MalformedURLException e) {
>
> The previous code looks like a hold-over from JDK 8, where jfxrt.jar was in
> `lib/ext`. It also assumes that the JavaFX
> runtime is being loaded from a jar URL, which isn't necessarily the case.
> Probably the only reason it hasn't caused
> problems before now is that it is only used to locate
> `javafx.platform.properties`. Worth noting is that we won't get
> here in the case JavaFX is jlinked into the Java runtime, although in that
> case, the fallback method of locating it
> relative to the JDK should be used. I'll take a closer look this specific
> change, but I think it should be OK. I'll
> defer the review as a whole to Johan.
I can confirm that this part of the fix is correct. The change to DPI looks
correct to me, too.
-------------
PR: https://git.openjdk.java.net/jfx/pull/193
