On Tue, 28 Apr 2020 15:36:53 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> The issue is that the toggles is not reliably unselected if an uncontained > value is set. > > The root is ChoiceBoxSelectionModel which doesn't update the index on > selecting an uncontained item, in particular it > fails to keep the invariant: > assertEquals(getItems().indexOf(selectedItem), selectedIndex); > > The fix here is to override select(item) to guarantee the assert. > > Added/removed ignore from tests that failed before and pass after the fix. > All other tests are passing before and after. This pull request has now been integrated. Changeset: 99f77475 Author: Jeanette Winzenburg <faste...@openjdk.org> Committer: Ajit Ghaisas <aghai...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/99f77475 Stats: 55 lines in 2 files changed: 7 ins; 44 del; 4 mod 8241999: ChoiceBox: incorrect toggle selected for uncontained Reviewed-by: aghaisas ------------- PR: https://git.openjdk.java.net/jfx/pull/200
