On Tue, 5 May 2020 10:38:56 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> I'll put this on my queue to review and test it. I left some high-level >> comments below. > > I would suggest making everything configurable in the original library which > will be suggested here to be changed. > I will now add the possibility to make the creation of the heapDump > configurable, and also the createGarbage method. > If something should behave differently by default, then I will just adjust > the default values for this copy of the > library. > I will improve the documentation in the original Library. How should I add > the documentation to the JavaFX project? > Ideally, I would just reference somewhere to the documentation of the > original library. How/Where should I do that? It's also worth mentioning that this utility allows checking whether an object can not be collected. This is important because the applications, which are using WeakReferences/WeakListeners often introduce bugs that are hard to debug because they only happen after the GC has been run. ------------- PR: https://git.openjdk.java.net/jfx/pull/204
