On Thu, 21 May 2020 18:11:59 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> After JDK-8242167, a JavaFX control is used for text input on iOS instead of 
>> the native control, on a touch enabled
>> device. However, selection handles are not enabled and currently text 
>> selection is not possible at all.
>> This PR enables handles on iOS as in the rest of the platforms with touch 
>> support.
>> 
>> It also tries to accommodate its style to the native style for handles, 
>> where selection handles have a circle shape and
>> are a little bit bigger, and there is no caret handle.
>
> Since this touches shared code, I'd like @aghaisas to look at this.

Code changes look OK.
I think, we need a note in PR description about what testing you have done with 
this fix.

-------------

PR: https://git.openjdk.java.net/jfx/pull/231

Reply via email to