> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the maximum possible size and > re-compositing the final snapshot out of these, is > currently only attempted after the original, non-tiled, strategy has already > failed. This was decided to avoid any risk > of regressions, either in terms of performances and correctness, while still > offering some relief to the original > issue. This follow-on issue aims to propose a fix to the original issue, > that is able to correctly decide on the best > snapshot strategy (tiled or not) to adopt before applying it and ensure best > performances possible when tiling is > necessary while still introducing no regressions compared to the original > solution.
Frederic Thevenet has updated the pull request incrementally with three additional commits since the last revision: - Use boolean[] instead of AtomicBoolean to effec pass-by-reference - Fixed typo in comment - Removed fully qualified name when declaring RTTexture ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/112/files - new: https://git.openjdk.java.net/jfx/pull/112/files/7f5f2890..1fb04e56 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/112/webrev.05 - incr: https://webrevs.openjdk.java.net/jfx/112/webrev.04-05 Stats: 126 lines in 1 file changed: 31 ins; 79 del; 16 mod Patch: https://git.openjdk.java.net/jfx/pull/112.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/112/head:pull/112 PR: https://git.openjdk.java.net/jfx/pull/112
