On Wed, 12 Feb 2020 13:21:03 GMT, Frederic Thevenet <github.com+7450507+ftheve...@openjdk.org> wrote:
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the maximum possible size and > re-compositing the final snapshot out of these, is > currently only attempted after the original, non-tiled, strategy has already > failed. This was decided to avoid any risk > of regressions, either in terms of performances and correctness, while still > offering some relief to the original > issue. This follow-on issue aims to propose a fix to the original issue, > that is able to correctly decide on the best > snapshot strategy (tiled or not) to adopt before applying it and ensure best > performances possible when tiling is > necessary while still introducing no regressions compared to the original > solution. This pull request has now been integrated. Changeset: 32584dba Author: Frederic Thevenet <thevenet.f...@free.fr> Committer: Kevin Rushforth <k...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/32584dba Stats: 395 lines in 3 files changed: 64 ins; 313 del; 18 mod 8238954: Improve performance of tiled snapshot rendering Reviewed-by: arapte, kcr ------------- PR: https://git.openjdk.java.net/jfx/pull/112
