On Fri, 7 Aug 2020 13:06:51 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> modules/javafx.base/src/main/java/javafx/util/converter/CurrencyStringConverter.java
>>  line 35:
>> 
>>> 34: /**
>>> 35:  * A {@link StringConverter} implementation for {@link Number} values 
>>> that represent currency. Instances of this
>>> class are immutable. 36:  *
>> 
>> Given that there are no setters or other mutator methods, the immutability 
>> seems obvious. I don't see a problem with
>> stating it explicitly, though. It's up to you.
>
> True, but I just looked at 
> [Border](https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/layout/Border.html)
> which states immutability, so I did the same. I don't mind changing it.

I don't mind either way.

-------------

PR: https://git.openjdk.java.net/jfx/pull/277

Reply via email to