On Mon, 14 Sep 2020 11:22:42 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed URL to WEBKIT-MEDIA-STUBS.md > > Additional comments: > > 1. "Use Unix-style (LF) line endings not DOS-style (CRLF)" needs a comma > before "not". > 2. "Line width is no more than 120 characters" I remember that it was 130 or > 135 somewhere. > 3. "Wildcard imports (import foo.bar.baz.*) are forbidden" Junit imports use > them extensively. > 4. `./gradlew all test` will cause failure on webkit tests if it was not > built. Regarding your additional comments: > * "Use Unix-style (LF) line endings not DOS-style (CRLF)" needs a comma > before "not". Fixed. > * "Line width is no more than 120 characters" I remember that it was 130 or > 135 somewhere. You're probably remembering an old version, but it's been 120 for a while now. > * "Wildcard imports (import foo.bar.baz.*) are forbidden" Junit imports use > them extensively. Fixed to add an exception for wildcard static imports in tests. > * `./gradlew all test` will cause failure on webkit tests if it was not built. Added a note about this and a pointer to the [Web Testing](WEBKIT-MEDIA-STUBS.md) doc. ------------- PR: https://git.openjdk.java.net/jfx/pull/303
