On Tue, 18 Aug 2020 19:50:55 GMT, Leon Linhart <github.com+4029915+themrmilchm...@openjdk.org> wrote:
> Hi, this PR fixes > [JDK-8251946](https://bugs.openjdk.java.net/browse/JDK-8251946) computing > whether the list was > actually modified instead of just returning `true`. The list was modified if > 1. it was not empty (modified by calling > `#clear()`), or if 2. it was modified as result of the `#addAll()` call. > > If you want any test coverage for this please let me know. > > I reported the issue a couple of days ago via web formula and waited for the > confirmation to open this PR but now I see > that @kevinrushforth (sorry for pinging) is already assigned to the JBS > issue. I'm not too familiar with how you handle > JBS issues or more specifically whether assigning is used to indicate that > the issue is in the assignee's "domain", or > that the assignee is already working on it. In the latter case, please feel > free to close this PR. (My OCA submission > is still pending anyway.) This pull request has now been integrated. Changeset: 78570225 Author: Leon Linhart <themrmilchm...@gmail.com> Committer: Nir Lisker <nlis...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/78570225 Stats: 28 lines in 3 files changed: 25 ins; 2 del; 1 mod 8251946: ObservableList.setAll does not conform to specification Reviewed-by: arapte, kcr ------------- PR: https://git.openjdk.java.net/jfx/pull/284
