On Sat, 28 Nov 2020 04:54:06 GMT, Arun Joseph <ajos...@openjdk.org> wrote:
>> We should use the public_suffix_list.dat file in the JDK instead. Reading >> the public_suffix_list.dat file is modified to be similar to >> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java). >> If the file is not present, `isPublicSuffix()` returns `false`, which is >> similar to how WebKit ignores the public suffix check when it is disabled. >> >> Test: Run PublicSuffixesTest.java > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Add doPrivileged block I verified that the doPrivileged change allows it to work with a security manager. The only issue I now see is related to the log warning. modules/javafx.web/src/main/java/com/sun/webkit/network/PublicSuffixes.java line 86: > 84: if (!pslFile.exists()) { > 85: logger.warning("Resource not found: ", > 86: "lib/security/public_suffix_list.dat"); This should be a single string, so you need to concatenate them. ------------- PR: https://git.openjdk.java.net/jfx/pull/324
