On Thu, 19 Nov 2020 12:20:47 GMT, Jeanette Winzenburg <[email protected]>
wrote:
> Cleanup of LabeledSkinBase to allow for switching skins
>
> - removed null check in listener on graphic's layoutBounds
> - added removal of listener in dispose
Looks good, added a minor comment to remove a FIXME note
modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
line 286:
> 284: }
> 285: } else {
> 286: // FIXME: this listener must be removed in dispose!
minor: the FIXME note should be removed.
-------------
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/355
