On Wed, 24 Feb 2021 07:11:57 GMT, Arun Joseph <[email protected]> wrote:

>> Timer in RunLoopGeneric has an open bug in WebKit 
>> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain 
>> active even after firing.
>> 
>> Reverting back to WebCore Timer for ScrollAnimation in Linux.
>
> Arun Joseph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add system test

The new test looks good, although in order to make it pass on my slower Ubuntu 
20.04 VM, I had to increase the sleep time to 500 ms and also add a sleep after 
the focus latch and before the scroll. See below.

tests/system/src/test/java/test/javafx/scene/web/WebPageTest.java line 135:

> 133: 
> 134:         assertTrue("Timeout when waiting for focus change ", 
> Util.await(webViewStateLatch));
> 135: 

I needed to add a `sleep(500)` here.

tests/system/src/test/java/test/javafx/scene/web/WebPageTest.java line 142:

> 140:         });
> 141: 
> 142:         Util.sleep(100);

I needed to change this to `sleep(500)`

-------------

PR: https://git.openjdk.java.net/jfx/pull/404

Reply via email to