On Mon, 12 Apr 2021 07:50:39 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Matthias Bläsing has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert changes to thread attachment introduced in second commit >> >> Thread attachment is handled in >> >> jfx/modules/javafx.web/src/main/native/Source/WebKitLegacy/Storage/StorageThread.cpp >> and thus does not need to be modified. > > I understand the crash would be at a different point, but it would still be a > crash, I think? That is, if the method handlers are correctly registered via > the OnLoad function, and later a new native thread tries to access a function > that is not yet attached, that will still crash, I believe. (at least, the > GetEnv will return NULL and that result is used later). > So while the 2 issues are not related, I think there are really 2 issues. @johanvos a quick comment as Matthias linked me on this. The reason I suggested re-looking is that there is no evidence of thread attachment being behind this problem in the discussion that happened on the NetBeans list, in fact this problem couldn't happen if the thread was unattached. It depends if that discussion was the only basis for assuming an issue with thread attachment exists? ------------- PR: https://git.openjdk.java.net/jfx/pull/458
