On Wed, 14 Apr 2021 14:38:05 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove mt.exe from win.gradle build script > > buildSrc/win.gradle line 46: > >> 44: def HOST_ARCH = getWinArch(ext.OS_ARCH) >> 45: def TARGET_ARCH = getWinArch(ext.TARGET_ARCH) >> 46: def IS_CROSS = HOST_ARCH != TARGET_ARCH > > can we move this to build.gradle? > With the increasing number of supported configurations, there will otherwise > be more gradle sub-files that have something similar. Yes, this does seem like a better plan. Should this be done as a follow-on or do you want to see it done now? One reason I ask is that my PR #462 (which is now approved, but waiting re-review) does something similar to `getWinArch()` to determine whether we are running on aarch64 or not and should be modified as well. ------------- PR: https://git.openjdk.java.net/jfx/pull/439
