On Mon, 12 Apr 2021 13:10:44 GMT, Kevin Rushforth <[email protected]> wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 1591:
>
>> 1589: adjustPositionToIndex(index);
>> 1590: // double offset = - computeOffsetForCell(index);
>> 1591: // adjustByPixelAmount(offset);
>
> I forgot to ask about this last time. Is there a reason to leave the former,
> now commented-out, code here, as opposed to just removing it?
no reason, corrected.
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 1903:
>
>> 1901: void setViewportLength(double value) {
>> 1902: this.viewportLength = value;
>> 1903: this.absoluteOffset = getPosition() * (estimatedSize
>> -viewportLength);
>
> Minor: spacing
solved this and the previous spacing comments.
-------------
PR: https://git.openjdk.java.net/jfx/pull/398
