On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos <[email protected]> wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed from this PR.
Other than that, the changes looks good.
build.gradle line 3465:
> 3463: def webkitProperties = targetProperties.webkit
> 3464: def classifier = (t.name != "linux" && t.name != "win") ?
> t.name :
> 3465: IS_64 ? IS_AARCH64 ? "${t.name}-aarch64" :
> "${t.name}-amd64" : "${t.name}-i586"
I don't think this change is necessary as `classifier` was used for
webview-deps, and it's not used anymore (removed in
https://github.com/openjdk/jfx/commit/bf203ad716633e8c9f23a70448fac1ed580a7fb5).
This `classifier` definition can also be removed.
-------------
PR: https://git.openjdk.java.net/jfx/pull/467