On Tue, 27 Apr 2021 02:09:54 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> Remote Desktop will change default audio device when connecting or >> disconnecting to it's own audio device. Also, when remote desktop is >> disconnect, then remote desktop default audio device is removed and system >> default device is not restored until user logs back to computer. So, after >> remote desktop is disconnected, then system left without any default audio >> devices. >> >> To fix this we will unload DirectSound when audio device is gone and will >> continue playback by throwing away audio data. Once we receive notification >> that default audio device is back, we will load it and continue playback via >> this device. >> >> Loading device done in loop, since it is not always available right after >> notification, but will be after very short period of time. >> >> Tested by connecting/disconnecting remote desktop and switching between >> remote and normal desktop. In second case audio will switch between remote >> or speakers. >> >> Since audio device is gone and not restored after disconnect, there will be >> no audio on machine local speakers, until user logs back again. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8264737: JavaFX media stream stops playing after reconnecting via Remote > Desktop [v2] Marked as reviewed by arapte (Reviewer). The change fixes the issue and looks good. While testing it regressively, I observed an issue. The issue can occur always. steps to reproduce: 1. Run Ensemble app on remote desktop 2. Run Streaming Media Player app 3. Press the media player buttons for several times. Keep pressing different buttons for a minute or more and at the end press stop backward. 4. Disconnect remote desktop and connect again 5. Press play button 6. I observed two different issues at two different instances - Video and audio bot do not play - Audio plays but video does not play However, Looking at the steps to reproduce this does not seem like a stopper to me, so approving Let me know if you can or cannot reproduce the issue, we can take that as a follow on issue. ------------- PR: https://git.openjdk.java.net/jfx/pull/479
