On Fri, 23 Apr 2021 15:31:52 GMT, Jeanette Winzenburg <[email protected]> 
wrote:

>> Issue is missing update of Tree-/TableCell's editiable state when changing 
>> its index from editingIndex to -1. 
>> 
>> Seems to be a left-over from fixing cell's editing update - done in 
>> [JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) - on index 
>> change for the special case of new index -1.
>> 
>> Fixed by cleaning out editing state in that corner case also, added tests 
>> that were failing before and passing after the fix. Note that there are also 
>> tests that passed before: the previous fix didn't add any tests, so added 
>> them here.
>
> Jeanette Winzenburg has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   changed doCancelEdit to reliably reset the flag updateEditingIndex

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/473

Reply via email to