On Mon, 3 May 2021 20:51:13 GMT, mstr2 <github.com+43553916+ms...@openjdk.org> wrote:
>> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added a bunch of >> tests. >> >> After applying this fix, I can no longer reproduce >> [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and >> [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228). > > mstr2 has updated the pull request incrementally with two additional commits > since the last revision: > > - Rename local variable in test > - Remove unrelated fix I've removed the clearSelection fix, which can be addressed in another PR. What remains is a fix for the underlying issue that the list of removed selected indices is incorrect when a tree branch is collapsed. The IOOB exception is an artifact of the elaborate test setup in [8189354](https://bugs.openjdk.java.net/browse/JDK-8189354). I propose to change the title of the JBS issue to `List of removed selected indices is incorrect when a tree branch is collapsed` and have this PR be the fix for that. ------------- PR: https://git.openjdk.java.net/jfx/pull/480
