On Tue, 29 Jun 2021 14:20:30 GMT, Johan Vos <[email protected]> wrote:
>> Make sure the returned fullName of a created font matches the requested
>> name. Since the name is used as a key/identifier in some cases, some
>> internal code relies on this.
>> Added a test to check the case of "System Font Regular" on MacOS, which
>> fails before and succeeds after the patch.
>
> Johan Vos has updated the pull request incrementally with one additional
> commit since the last revision:
>
> rename test
modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java
line 612:
> 610: if (name != null) {
> 611: fullName = name;
> 612: }
So I suppose this is predicated on the assumption that the name being passed in
is retrieved from the platform for *all* platforms (not just Mac) so we are
sure it is a valid name ?
I'd be interested to see what the difference is in the full names we then
display on each platform and whether locale matters .. the name got from the
platform might be a locale name and that may not have been the intention here
.. and is it possible "name" has already had toLowerCase() called on it ?
-------------
PR: https://git.openjdk.java.net/jfx/pull/553
