On Mon, 5 Jul 2021 10:18:15 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> the bug is an incorrect edit location (for Tree/Table: Tree/TablePosition) >> in edit cancel events - expected is the location at the time the cell edit >> was started, actual was the location of at the time the edit was cancelled. >> See the report for details. >> >> The fix is analogue to those for ListCell/TreeCell, that is storing the edit >> location in startEdit and use that in cancelEdit. >> >> Added tests that failed before and passed after and tests that (accidentally >> :) passed before and still pass after. >> >> Related issues: >> >> - also fixes [JDK-8269136](https://bugs.openjdk.java.net/browse/JDK-8269136) >> (Tree/TablePosition: must not throw NPE on instantiating with null table), >> in hind-sight it seemed too small to warrant its own PR. >> - does not fix the implementation of CellEditEvent (todo: file follow-up >> issue) which must not throw with null Tree/TablePosition. > > Jeanette Winzenburg has updated the pull request incrementally with one > additional commit since the last revision: > > test cleanup as per review comments Marked as reviewed by aghaisas (Reviewer). ------------- PR: https://git.openjdk.java.net/jfx/pull/561