On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal <[email protected]> wrote:
> The bug is a regression as a result of fix done for JDK-8227366 and is
> reproducible on Linux and Mac. This fix is being reverted in this change and
> a new bug (JDK-8271054) has been created to redo the JDK-8227366
>
> An automated testcase is being added to make sure similar regression is not
> introduced when working on the redo bug. The automated testcase fails without
> the current change and passes after the change.
>
> The testcase works fine on Mac and Linux, but I see some issues in windows.
> The stage is minimised after calling stage.show without calling
> stage.setAlwaysOnTop(true). I see that there are other tests like
> DualWindowsTest.java which are failing for same reason. Also, if I remove the
> stage.setAlwaysOnTop(true) from tests like
> FocusParentWindowOnChildCloseTest.java, the stage remains minimised there as
> well. This seems wrong as calling stage.setAlwaysOnTop(true) should not be
> required to bring stage window in focus on running the test. This may be an
> issue on my Window machine or something similar. I hope reviewers can shed
> some light on this.
tests/system/src/test/java/test/robot/javafx/stage/WrongStageFocusWithApplicationModalityTest.java
line 59:
> 57: @Test(timeout = 25000)
> 58: public void testWindowFocusByClosingAlerts() throws Exception {
> 59: Thread.sleep(1000);
On my slower Linux machine if I change this to `sleep(3000)` it passes
reliably. Given that you are opening up multiple dialogs, this seems like a
reasonable change.
-------------
PR: https://git.openjdk.java.net/jfx/pull/581
