On Mon, 23 Aug 2021 14:17:20 GMT, Christian Stein <cst...@openjdk.org> wrote:

>> build.gradle line 3929:
>> 
>>> 3927:             options.compilerArgs.addAll([
>>> 3928:                 '-implicit:none',
>>> 3929:                 '--module-version', "$RELEASE_VERSION_SHORT",
>> 
>> I'm not sure this is needed (although it doesn't hurt), since the shims are 
>> only used for testing and are not included in any jar file.
>
> Seeing version information in stack traces of failed tests can be helpful. ;-)

OK, that seems reasonable, and I can't think of any downside.

-------------

PR: https://git.openjdk.java.net/jfx/pull/608

Reply via email to