On Tue, 26 Oct 2021 19:48:41 GMT, Andreas Heger <d...@openjdk.java.net> wrote:
>> The inconsistent illumination happens on Macs with retina displays only if >> the 3D shape is placed in a SubScene. The light sources are located with >> wrong coordinates in sub scenes and this causes a different illumination. >> The wrong coordinates for the light sources come from the fact that the >> retina pixel scale factors are not used in a SubScene. >> >> With this pull request, the retina pixel scale factors will be also used in >> SubScenes and this should resolve the bug >> [https://bugs.openjdk.java.net/browse/JDK-8255015](url) > > Andreas Heger has updated the pull request incrementally with one additional > commit since the last revision: > > 8255015: testScene variable must be volatile and new line at the end of the > file added Looks good to me. The copyright year in test file needs to be changed. Along with it please fix the suggested minor typo. tests/system/src/test/java/test/robot/test3d/PointLightIlluminationTest.java line 2: > 1: /* > 2: * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights > reserved. It should have only one copyright year: 2021. -> `* Copyright (c) 2021, Oracle and/o` tests/system/src/test/java/test/robot/test3d/PointLightIlluminationTest.java line 148: > 146: * Creates a new scene with a subscene which contains a perspective > camera and a sphere > 147: * Although this test class checks the pointlight illumination, > there is no explicit pointlight > 148: * in the scene. For the test, it is sufficient to use the default > pointlight which is created minor: Please include this small correction along with the copyright year change. pointlight -> point light ------------- Changes requested by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/531
