On Wed, 17 Nov 2021 05:34:46 GMT, Abhinay Agarwal <d...@openjdk.java.net> wrote:

> This work improves the performance of `MultipleSelectionModel`  over large 
> data sets by caching some values and avoiding unnecessary calls to 
> `SelectedIndicesList#size`. It further improves the performance by reducing 
> the number of iterations required to find the index of an element in the 
> BitSet.
> 
> The work is based on [an abandoned 
> patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs
> 
> There are currently 2 manual tests for this fix.

tests/manual/controls/SelectListViewTest.java line 18:

> 16:     //  final int ROW_COUNT = 10_000_000;
> 17:     // final int ROW_COUNT = 7_000;
> 18: 

There is a duplication of the number of test data.

My test is below.

``` Java
public class SelectListViewTest extends Application {
        final int ROW_COUNT = 70_000;
//      final int ROW_COUNT = 400_000;
//      final int ROW_COUNT = 10_000_000;
//      final int ROW_COUNT = 7_000;

-------------

PR: https://git.openjdk.java.net/jfx/pull/673

Reply via email to