> There was a mismatch between the way `get_glass_key` generated the Java key > code for a given key press and how `getKeyCodeForChar` determined the key > code for the matching character. For example, when pressing the plus sign on > a US keyboard `get_glass_key` correctly generated `KeyCode.EQUALS` but > `getKeyCodeForChar("+")` generated `KeyCode.PLUS`. > > In this PR `getKeyCodeForChar` mirrors the behavior of `get_glass_key`; it > determines which key the character lies on and generates a key code based on > the unshifted character on the same key. > > I'm working on a more comprehensive test case that allows you to press any > key on the keyboard and test whether a KeyCharacterCombination for that > character will succeed or not. I've attached it to this thread. It might be > worth submitting as a manual test case > [CharComboTest.txt](https://github.com/openjdk/jfx/files/7247265/CharComboTest.txt) > .
Martin Fox has updated the pull request incrementally with one additional commit since the last revision: Learn-as-they-type approach to implementing getKeyCodeForChar ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/635/files - new: https://git.openjdk.java.net/jfx/pull/635/files/69d46c2e..80606863 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=635&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=635&range=02-03 Stats: 77 lines in 1 file changed: 77 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/635.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/635/head:pull/635 PR: https://git.openjdk.java.net/jfx/pull/635