On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a link to the mailing list in the section regarding contributing bug >> fixes. >> 3. Remove the text about cross-linking the PR and JBS issue, and add a note >> that the Skara tooling takes care of this >> 4. Remove the section about manually resolving the JBS issue, and add a note >> that the Skara bot automatically does this when the PR is integrated. >> 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate >> 6. Update the note regarding which JDK(s) to use. > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Minor updates I added 1 suggestion. CONTRIBUTING.md line 204: > 202: section of the Code Review Policies doc, we also need a > [CSR](https://wiki.openjdk.java.net/display/csr/Main), which documents the > API change and its approval. > 203: The CSR can be reviewed in parallel. Changes in the API that arise > during the review need to be reflected in the CSR, meaning > 204: that the final review / approval of the CSR usually happens late in the > review cycle. I would advise contributors to not deal with the CSR until the review is almost done. It just duplicates the places that you need to update. I'm saying this from personal experience :) ------------- Marked as reviewed by nlisker (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/303
