On Thu, 27 Jan 2022 19:57:13 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to `LightBase` >> since different light types share characteristics. `LightBase` now contains >> a summary of its subtypes and all the explanations of the >> properties/characteristics of the lights divided into sections: Color, >> Scope, Direction, Attenuation. >> * Each light type links to the relevant section in `LightBase` when it >> mentioned the properties it has. >> * Added examples of real-world applications for each light type. >> * Consolidated the writing style for all the subclasses. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed table accessibility The latest changes all look good. The only open question is around the description of `AmbientLight`. ------------- PR: https://git.openjdk.java.net/jfx/pull/717
